Removing one nat rule restriction in a nat rule collection - Firewall Policy[DO NOT MERGE] #9246

saisujithreddym · 2020-04-27T20:28:18Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-04-27T20:28:34Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-04-27T20:30:07Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 50bd5a5 with merge commit eb69745ce76773f543d00471fe0c1b865b1afb1f. SDK Automation 13.0.17.20200424.4
⚠️network/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-03-30 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-09-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2016-12-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-03-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-09-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2017-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-01-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-10-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2018-12-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-07-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-09-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-11-01 [Logs]
```
No file is changed.
```
⚠️network/mgmt/2019-12-01 [Logs]
```
No file is changed.
```
⚠️preview/network/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-04-27T20:30:07Z

azure-sdk-for-net

🔄 inProgress [Logs] [Expand Details]

🔄 Generate from 50bd5a5 with merge commit eb69745ce76773f543d00471fe0c1b865b1afb1f. SDK Automation 13.0.17.20200424.4

openapi-sdkautomation · 2020-04-27T20:30:09Z

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-27T20:30:09Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 50bd5a5 with merge commit eb69745ce76773f543d00471fe0c1b865b1afb1f. SDK Automation 13.0.17.20200424.4
⚠️sdk/network/mgmt-v2019_02_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_04_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_06_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_07_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_08_01 [Logs]
```
No file is changed.
```
⚠️sdk/network/mgmt-v2019_09_01 [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-04-27T20:30:10Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 50bd5a5 with merge commit eb69745ce76773f543d00471fe0c1b865b1afb1f. SDK Automation 13.0.17.20200424.4
️✔️@azure/arm-network [Logs] [Preview SDK Changes]
- azure-arm-network-21.0.0.tgz

openapi-sdkautomation · 2020-04-27T20:30:12Z

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 50bd5a5 with merge commit eb69745ce76773f543d00471fe0c1b865b1afb1f. SDK Automation 13.0.17.20200424.4
```
Failed to find any diff after autorest so no changed packages was found.
```

azuresdkci · 2020-04-27T21:02:37Z

Can one of the admins verify this patch?

saisujithreddym · 2020-05-04T17:50:24Z

I will make this PR against the may release branch. Closing this for now

making nat rule into a collection

50bd5a5

saisujithreddym requested review from MikhailTryakhov, anton-evseev and v-shhatt as code owners April 27, 2020 20:28

openapi-assignment-bot bot assigned lirenhe Apr 27, 2020

saisujithreddym changed the title ~~Removing one nat rule restriction in a nat rule collection~~ Removing one nat rule restriction in a nat rule collection - Firewall Policy Apr 27, 2020

openapi-sdkautomation bot mentioned this pull request Apr 27, 2020

[AutoPR @azure/arm-network] Removing one nat rule restriction in a nat rule collection - Firewall Policy AzureSDKAutomation/azure-sdk-for-js#1144

Open

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 28, 2020

lirenhe approved these changes Apr 29, 2020

View reviewed changes

saisujithreddym changed the title ~~Removing one nat rule restriction in a nat rule collection - Firewall Policy~~ Removing one nat rule restriction in a nat rule collection - Firewall Policy[DO NOT MERGE] Apr 29, 2020

anton-evseev added the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 4, 2020

saisujithreddym closed this May 4, 2020

saisujithreddym mentioned this pull request May 7, 2020

Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup #9356

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing one nat rule restriction in a nat rule collection - Firewall Policy[DO NOT MERGE] #9246

Removing one nat rule restriction in a nat rule collection - Firewall Policy[DO NOT MERGE] #9246

saisujithreddym commented Apr 27, 2020 •

edited by lirenhe

Loading

azure-pipelines bot commented Apr 27, 2020

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

azuresdkci commented Apr 27, 2020

saisujithreddym commented May 4, 2020

Removing one nat rule restriction in a nat rule collection - Firewall Policy[DO NOT MERGE] #9246

Removing one nat rule restriction in a nat rule collection - Firewall Policy[DO NOT MERGE] #9246

Conversation

saisujithreddym commented Apr 27, 2020 • edited by lirenhe Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Apr 27, 2020

openapi-sdkautomation bot commented Apr 27, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Apr 27, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Apr 27, 2020 • edited Loading

azure-cli-extensions

openapi-sdkautomation bot commented Apr 27, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Apr 27, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Apr 27, 2020 • edited Loading

azure-sdk-for-python

azuresdkci commented Apr 27, 2020

saisujithreddym commented May 4, 2020

saisujithreddym commented Apr 27, 2020 •

edited by lirenhe

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 27, 2020 •

edited

Loading